Logtabwindowrefactor #522
Merged
Logtabwindowrefactor #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 17, 2025 11:37
…aller and less packed
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings across the codebase, focusing on interface updates, resource handling, and expanded test coverage. The most significant changes include standardizing callback and memory interfaces, adding new localized error messages, and introducing comprehensive unit tests for the
LedIndicatorService. Additionally, there are minor code cleanups and method signature updates to improve consistency and reliability.Interface and API updates:
ILogExpertCallbackMemoryandILogLineMemoryinstead of their previous counterparts, improving clarity and enforcing the use of memory-based log line handling. (src/ColumnizerLib/IKeywordAction.cs,src/DefaultPlugins/ProcessLauncher.cs,src/LogExpert.Core/EventArguments/ContextMenuPluginEventArgs.cs,src/LogExpert.Core/Classes/Filter/FilterPipe.cs) [1] [2] [3] [4] [5] [6] [7] [8]ILogWindowinterface:WritePipeTab(IList<LineEntryMemory> lineEntryList, string title), supporting memory-based line entries for piping content into new tabs. (src/LogExpert.Core/Interface/ILogWindow.cs)Localization and resource improvements:
src/LogExpert.Resources/Resources.Designer.cs,src/LogExpert.Resources/Resources.resx,src/LogExpert.Resources/Resources.de.resx) [1] [2] [3]Testing enhancements:
LedIndicatorService, covering initialization, icon generation, lifecycle management, event handling, and error scenarios. (src/LogExpert.Tests/Services/LedIndicatorServiceTests.cs)Code cleanup and reliability:
FilterPipe. (src/LogExpert.Core/Classes/Filter/FilterPipe.cs)LogfileReaderfor more precise resource management. (src/LogExpert.Core/Classes/Log/LogfileReader.cs)using System;directives for cleaner code. (src/ColumnizerLib/IKeywordAction.cs,src/DefaultPlugins/ProcessLauncher.cs) [1] [2]These changes collectively improve code maintainability, interface clarity, localization coverage, and test reliability.